Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix call to quiesce_uploads in topic deletion test #11684

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jun 26, 2023

This was a case of passing topic_name instead of [topic_name], python helpfully accepting a string as something to iterate over, rpk topic describe not throwing an error on a missing topic, and quiesce_uploads not throwing an error of rpk gives it zero partition descriptions.

Fixes #8496
Fixes #10655
Fixes #9629

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

jcsp added 3 commits June 26, 2023 11:14
This function was building a list, and then
iter-izing in during return.  Since we return
an iterator, we might as well just yield as we go.
This function could get zero partitions from its call
to `rpk topic describe`, and would proceed immediately
without waiting for anything.

We expect to always be called for a topic that exists,
so throw an exception if describing the topic doesn't
get us any partitions.
This fixes commit 8355e4e

quiesce_uploads would fail silently if you called it for
a topic that didn't exist: that's fixed in the previous
commit.

This commit fixes the underlying issue, that we were
passing a string instead of a list of strings, so
quiesce_upload was trying to wait for each character
in the string as if it was a topic name.

Fixes redpanda-data#8496
Fixes redpanda-data#10655
Fixes redpanda-data#9629
@jcsp jcsp added kind/bug Something isn't working area/tests area/cloud-storage Shadow indexing subsystem labels Jun 26, 2023
@jcsp
Copy link
Contributor Author

jcsp commented Jun 26, 2023

Failures are:

@jcsp jcsp marked this pull request as ready for review June 26, 2023 13:07
@jcsp jcsp requested a review from VladLazar June 26, 2023 13:08
@jcsp jcsp merged commit 01ec858 into redpanda-data:dev Jun 26, 2023
@jcsp jcsp deleted the issue-10655-delete-topic-again branch June 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-storage Shadow indexing subsystem area/tests kind/bug Something isn't working
Projects
None yet
2 participants